| To: | Jeff Garzik <jgarzik@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2.6] natsemi.c NAPI |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Mon, 20 Sep 2004 12:12:39 -0700 |
| Cc: | laforge@xxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20040920190746.GA17210@havoc.gtf.org> |
| References: | <20040920141030.GV1307@sunbeam.de.gnumonks.org> <20040920115746.7ccbfb45.davem@davemloft.net> <20040920190746.GA17210@havoc.gtf.org> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Mon, 20 Sep 2004 15:07:46 -0400 Jeff Garzik <jgarzik@xxxxxxxxx> wrote: > On Mon, Sep 20, 2004 at 11:57:46AM -0700, David S. Miller wrote: > > This driver (before the NAPI patch) is a bit buggy, it does > > no RX processing SMP locking. So if one one cpu you're doing > > RX interrupt processing, and on another cpu tx_timeout() runs > > we're totally screwed. > > RX processing in current natsemi only happens in irq, and the natsemi > driver properly disables irqs when it needs to, AFAICS, using > enable/disable_irq(). Aha, ok that works. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Clean up fib_hash datastructures, David S. Miller |
|---|---|
| Next by Date: | "dst cache overflow", Robert Olsson |
| Previous by Thread: | Re: [PATCH 2.6] natsemi.c NAPI, Jeff Garzik |
| Next by Thread: | Re: [PATCH 2.6] natsemi.c NAPI, Harald Welte |
| Indexes: | [Date] [Thread] [Top] [All Lists] |