| To: | hadi@xxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH] Clean up fib_hash datastructures |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Sun, 19 Sep 2004 19:46:42 -0700 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <1095640781.1047.168.camel@jzny.localdomain> |
| References: | <20040918203319.24004d6e.davem@davemloft.net> <1095640781.1047.168.camel@jzny.localdomain> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On 19 Sep 2004 20:39:43 -0400 jamal <hadi@xxxxxxxxxx> wrote: > Will look at rest of patch and get back to you. Curious piece like you > note: > > > Does anyone know what this test: > > > > if (!iter->zone->fz_next) > > continue; > > > > in fib_get_first() is doing? I kept it there > > but it looks fishy. > > Yes, it is fishy;-> patch attached. Probably one of the more interesting > typos i have seen recently Aha, yes, if you look at the original code before this stuff was converted to use seq_file, and therefore the 2.4.x copy of this code, the typo is even more obvious. Good spotting Jamal. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Improve behaviour of Netlink Sockets, jamal |
|---|---|
| Next by Date: | Re: 2.6.9-rc1-bk11+ and 2.6.9-rc1-mm3,4 r8169: freeze during boot (FIX included), Jeff Garzik |
| Previous by Thread: | Re: [PATCH] Clean up fib_hash datastructures, jamal |
| Next by Thread: | Re: [PATCH] Clean up fib_hash datastructures, Herbert Xu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |