Re: [PATCH] acenic - don't spin in hard_start_xmit when ring fills

["David S. Miller" <davem@xxxxxxxxxxxxx>]

On Fri, 17 Sep 2004 09:02:17 -0700
Stephen Hemminger <shemminger@xxxxxxxx> wrote:

> On Thu, 16 Sep 2004 16:50:42 -0700
> "David S. Miller" <davem@xxxxxxxxxxxxx> wrote:
> 
> > 1) Accept this spinning performance characteristic of the
> >    acenic driver.
> 
> What if there is buggy, hardware that never drains the ring.
> It can happen.

You're preaching to the choir :-)  I've been bugging Alexey about
this aspect of the Acenic driver since day one.

> > 2) Finally give up on acenic's clever lockless scheme and add
> >    the necessary locking + start/stop tx flow control so it
> >    will never have to return TX_BUSY except in absolutely
> >    catastrophic failure cases.
> 
> I'll code up a non-lockless version and see if makes any real difference.

Let me know how it goes.