netdev
[Top] [All Lists]

Re: [RTNETLINK] Convert RTM_* to enum

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [RTNETLINK] Convert RTM_* to enum
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 15 Sep 2004 14:45:55 +1000
Cc: jmorris@xxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040914213837.75634b93.davem@davemloft.net>
References: <20040915020942.GA32721@gondor.apana.org.au> <Xine.LNX.4.44.0409142337130.28280-100000@thoron.boston.redhat.com> <20040915034748.GA952@gondor.apana.org.au> <20040914213837.75634b93.davem@davemloft.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Tue, Sep 14, 2004 at 09:38:37PM -0700, David S. Miller wrote:
> 
> Right.  If we start using defines we have to keep them around.
> I know it's bogus for people to ifdef this stuff, but we know
> they do, and it's in bad taste to knowingly break stuff like that.

How about if we make it a rule that we only add new enum constants
but not macros?

> Anyways, I'll apply your patch Herbert, thanks.

Thanks.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>