On Mon, 13 Sep 2004 14:59:44 -0700 (PDT)
S P <speattle@xxxxxxxxx> wrote:
Your email client linewraps the patches and also transforms
tabs into spaces making your patches un-applyable. Please fix
for future submissions, thanks.
Now, onto the patch itself. I think we're adding more tense
errors than we're removing. For example:
> - All real intelligent work is done inside qdisc
> modules.
> + All real intelligent work is done inside each
> qdisc modules.
'each' indicates singularity, yes "modules" is still
plural. I would change it instead to:
All the real intelligent work is done inside
the qdisc modules.
> - but it does not mean that queue is empty, it just
> means that
> - discipline does not want to send anything this
> time.
> + but it does not mean the queue is empty; it means
> that
> + the discipline does not want to send anything this
> time.
This one looks fine.
> - For complicated disciplines with multiple queues
> q->q is not
> - real packet queue, but however q->q.qlen must be
> valid.
> + For complicated disciplines with multiple queues,
> q->q is not
> + real packet queue whereas q->q.qlen must be valid.
Looks fine, we're missing an articles here.
So maybe the final version of this verse is:
For complicated disciplines with multiple queues,
q->q is not a real packet queue whereas q->q.qlen
must be valid.
The rest looks fine.
|