netdev
[Top] [All Lists]

Re: [PATCH 2.6] ip_nat_ftp - manip at the right place

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH 2.6] ip_nat_ftp - manip at the right place
From: Harald Welte <laforge@xxxxxxxxxxxxx>
Date: Sat, 11 Sep 2004 23:57:46 +0200
Cc: Netfilter Development Mailinglist <netfilter-devel@xxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, Rusty Russell <rusty@xxxxxxxxxxxxxxx>
In-reply-to: <Pine.LNX.4.58.0409111042580.1315@u.domain.uli>
Mail-followup-to: Harald Welte <laforge@xxxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, Netfilter Development Mailinglist <netfilter-devel@xxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, Rusty Russell <rusty@xxxxxxxxxxxxxxx>
References: <Pine.LNX.4.58.0409111042580.1315@u.domain.uli>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Sat, Sep 11, 2004 at 10:53:53AM +0300, Julian Anastasov wrote:
>       Hello,
> 
>       This is a resend/resync for v2.6.9-rc1-bk17: change the
> way the ip_nat_ftp helper manipulates the packets:
> 
> - no manips => no fixup
> 
> - check the direction, do manip once and at the same time when the
> headers are changed

I agree with this change, but shouldn't we make it consistently over all
NAT helpers?  In case you didn't check yet, and assuming that this is
applicable to other helpers as well:  Please include patches for other
protocol helpers as well.

Thanks!

> Signed-off-by: Julian Anastasov <ja@xxxxxx>
-- 
- Harald Welte <laforge@xxxxxxxxxxxxx>             http://www.netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>