netdev
[Top] [All Lists]

Re: iproute2 patch introducing mtu/txqlen/weight via rtnetlink

To: tgraf@xxxxxxx
Subject: Re: iproute2 patch introducing mtu/txqlen/weight via rtnetlink
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxx>
Date: Fri, 10 Sep 2004 10:33:41 +0900 (JST)
Cc: davem@xxxxxxxxxxxxx, hadi@xxxxxxxxxx, shemminger@xxxxxxxx, eric.lemoine@xxxxxxxxx, netdev@xxxxxxxxxxx, yoshfuji@xxxxxxxxxx
In-reply-to: <20040909175411.GB19155@postel.suug.ch>
Organization: USAGI Project
References: <20040909164834.GB18994@postel.suug.ch> <20040909103344.5a448b01.davem@davemloft.net> <20040909175411.GB19155@postel.suug.ch>
Sender: netdev-bounce@xxxxxxxxxxx
In article <20040909175411.GB19155@xxxxxxxxxxxxxx> (at Thu, 9 Sep 2004 19:54:11 
+0200), Thomas Graf <tgraf@xxxxxxx> says:

> * David S. Miller <20040909103344.5a448b01.davem@xxxxxxxxxxxxx> 2004-09-09 
> 10:33
> > On Thu, 9 Sep 2004 18:48:34 +0200
> > Thomas Graf <tgraf@xxxxxxx> wrote:
> > 
> > > - Convert mtu and txqlen to use rtnetlink instead of ioctl.
> > > - Introduces weight.
> > > - Updates local copy of rtnetlink.h.
> > > 
> > > Against iproute2-2.6.9-jamal, tested and working.
> > > Will look into remaining ioctls later.
> > 
> > Please don't blindly update rtnetlink.h in iproute2 with
> > the current kernel copy.  The "__KERNEL__" ifdef area
> > is omitted on purpose, yet you added it back in.
> 
> Sorry, included old patch, this is a correct one:

Well, I think we should maintain old ioctl path for backward compatibility.
(or ifdefs at least.)

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

<Prev in Thread] Current Thread [Next in Thread>