On Thu, Sep 09, 2004 at 10:27:36AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
>
> > > And, I think
> > > u16 ecn = (iph->tos + 1) & INET_ECN_MASK;
> > > check += (u32)htons(0xfffb) + (u32)htons(ecn);
> >
> > The second htons is less optimal than the shift because htons doesn't
> > know that ecn is only a byte. So it'll end up doing a full swap.
>
> Not true; gcc is clever enough to produces same code, and my code looks
> better.
Sorry, you're right. Here is an updated patch.
Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
p
Description: Text document
|