On Thu, Sep 09, 2004 at 09:24:28AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
>
> s/__constant_htons/htons/g here, please.
Good point.
> And, I think
> u16 ecn = (iph->tos + 1) & INET_ECN_MASK;
> check += (u32)htons(0xfffb) + (u32)htons(ecn);
The second htons is less optimal than the shift because htons doesn't
know that ecn is only a byte. So it'll end up doing a full swap.
Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
p
Description: Text document
|