Re: [PATCH 2.6]: Fix suboptimal fragment sizing for last fragment

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Fri, Sep 03, 2004 at 10:40:50AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
>
> @@ -1026,18 +1033,22 @@
>  
>       while (size > 0) {
>               int i;
> -             if ((len = mtu - skb->len) <= 0) {
> +
> +             /* Check if the remaining data fits into current packet. */
> +             len = mtu - skb->len;
> +             if (len > size)
> +                     len = maxfraglen - skb->len;

I think that should be len < size, right?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt