netdev
[Top] [All Lists]

Re: [RFC] acx100 inclusion in mainline; generic 802.11 stack

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [RFC] acx100 inclusion in mainline; generic 802.11 stack
From: Sam Leffler <sam@xxxxxxxxx>
Date: Mon, 6 Sep 2004 21:32:49 -0700
Cc: vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx, jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx, acx100-devel@xxxxxxxxxxxxxxxxxxxxx, jt@xxxxxxxxxxxxxxxxxx, jkmaline@xxxxxxxxx, prism54-devel@xxxxxxxxxxx
In-reply-to: <20040906182328.08faf843.davem@davemloft.net>
Organization: Errno Consulting
References: <200408312111.02438.vda@port.imtp.ilyichevsk.odessa.ua> <757AB580-0030-11D9-9224-000A95AD0668@errno.com> <20040906182328.08faf843.davem@davemloft.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.6.2
On Monday 06 September 2004 06:23 pm, David S. Miller wrote:
> On Mon, 6 Sep 2004 11:13:31 -0700
>
> Sam Leffler <sam@xxxxxxxxx> wrote:
> > I've suggested this code as a good starting point for a "generic 802.11
> > stack" but received only misinformed responses.
>
> Sam, I've told you multiple times why your stack isn't a good
> starting point.  It isn't implemented as a true network stack,
> like IPV4, Appletalk, etc.  Instead it's a gross input packet
> hooked packet eater thing that's an ugly wart bolted onto the
> side of the driver API.

Actually, this is the first time you've said anything to me about this code.  
We corresponded intensely for about a week 2+ years ago after which you 
declared you now knew how to "write an 802.11 stack right" and were going to 
do it that weekend.  I waited but it seems the sum total result was the shell 
of code that Jeff referenced in a previous note.

Perhaps you can point me at a description of what a "true network stack" means 
to you.  I'm guessing this has to do with your wanting queues inserted at 
various places instead of direct handoffs.  Regardless, I've never suggested 
the current code is suitable as-is but rather should be reshaped to suit the 
intended structure of the system.  There is a lot of hard-earned experience 
in the code that is independent of coding style and operational 
infrastructure.

Anyway, the point of my note was to correct a comment in the original posting 
and make folks aware that working code existed from which they could crib 
stuff.  Good luck finding someone to reimplement eveything according to your 
wishes.

        Sam

<Prev in Thread] Current Thread [Next in Thread>