| To: | David Miller <davem@xxxxxxxxxx> |
|---|---|
| Subject: | [PATCH] bridge deadlock on device removal |
| From: | Stephen Hemminger <shemminger@xxxxxxxx> |
| Date: | Mon, 6 Sep 2004 05:15:23 -0700 |
| Cc: | netdev@xxxxxxxxxxx |
| Organization: | OSDL |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Fixes: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=131569 Dead lock in bridge when removing device interface module. br_del_if assumes br->lock not held. This fixes case of: brctl addbr b0 brctl addif b0 eth0 rmmod eth0 Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxx> diff -Nru a/net/bridge/br_notify.c b/net/bridge/br_notify.c --- a/net/bridge/br_notify.c 2004-09-06 04:45:31 -07:00 +++ b/net/bridge/br_notify.c 2004-09-06 04:45:31 -07:00 @@ -76,10 +76,12 @@ break; case NETDEV_UNREGISTER: + spin_unlock_bh(&br->lock); br_del_if(br, dev); - break; + goto done; } spin_unlock_bh(&br->lock); + done: return NOTIFY_DONE; } |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | PPP-over-L2TP kernel support, patch for review, James Chapman |
|---|---|
| Next by Date: | Re: [PATCH] remove iph5526 driver, Christoph Hellwig |
| Previous by Thread: | PPP-over-L2TP kernel support, patch for review, James Chapman |
| Next by Thread: | Re: [PATCH] bridge deadlock on device removal, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |