| To: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Too late check in af_packet.c |
| From: | Dave Jones <davej@xxxxxxxxxx> |
| Date: | Fri, 3 Sep 2004 21:52:06 +0100 |
| Cc: | netdev@xxxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
Using the automated source checker at coverity.com, they picked up
on some code in packet_release() where a NULL check was done
after dereferencing. Patch below.
Signed-off-by: Dave Jones <davej@xxxxxxxxxx>
Dave
--- linux-2.6.8/net/packet/af_packet.c~ 2004-09-03 21:48:14.653433072 +0100
+++ linux-2.6.8/net/packet/af_packet.c 2004-09-03 21:49:23.652943552 +0100
@@ -785,11 +785,13 @@
static int packet_release(struct socket *sock)
{
struct sock *sk = sock->sk;
- struct packet_opt *po = pkt_sk(sk);
+ struct packet_opt *po;
if (!sk)
return 0;
+ po = pkt_sk(sk);
+
write_lock_bh(&packet_sklist_lock);
sk_del_node_init(sk);
write_unlock_bh(&packet_sklist_lock);
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2.6] watch64: generic variable monitoring system, Josef 'Jeff' Sipek |
|---|---|
| Next by Date: | Re: [PATCH 2.6] watch64: generic variable monitoring system, Josef 'Jeff' Sipek |
| Previous by Thread: | [PATCH/RFC 2.6] NET: 64-bit network statistics, josef Jeff Sipek |
| Next by Thread: | Re: Too late check in af_packet.c, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |