netdev
[Top] [All Lists]

Re: [PATCH 2.6]: Fix suboptimal fragment sizing for last fragment

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [PATCH 2.6]: Fix suboptimal fragment sizing for last fragment
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 2 Sep 2004 14:44:36 -0700
Cc: yoshfuji@xxxxxxxxxxxxxx, herbert@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <4137681D.3000902@trash.net>
References: <4137681D.3000902@trash.net>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 02 Sep 2004 20:36:13 +0200
Patrick McHardy <kaber@xxxxxxxxx> wrote:

> This patch always builds mtu sized fragments and truncates the previous
> fragment to a multiple of 8 bytes when allocating a new one. With the
> patch the dump looks like this:

Looks great Patrick, applied.

I see only one remaining possible improvement.  If the fraggap
area is paged data, we probably should try use page frags
in the new SKB if this split occurs in ip_append_page().

<Prev in Thread] Current Thread [Next in Thread>