netdev
[Top] [All Lists]

Re: neigh_create/inetdev_destroy race?

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: neigh_create/inetdev_destroy race?
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 2 Sep 2004 23:06:05 +1000
Cc: shemminger@xxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040901222118.0ce4bcc6.davem@davemloft.net>
References: <20040814013030.GA2042@gondor.apana.org.au> <20040814050848.GA11874@gondor.apana.org.au> <20040814062703.GA4806@gondor.apana.org.au> <20040815191450.77532d5d.davem@redhat.com> <20040816105131.GA11299@gondor.apana.org.au> <20040828234201.79556f6e.davem@davemloft.net> <20040829065031.GA786@gondor.apana.org.au> <20040830230820.7514985d.davem@davemloft.net> <20040831104139.GA2124@gondor.apana.org.au> <20040901222118.0ce4bcc6.davem@davemloft.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Wed, Sep 01, 2004 at 10:21:18PM -0700, David S. Miller wrote:
> 
> So here's the first step.  No rcu_read_lock()'s are needed
> since the tbl->lock needs to be held as a write when
> traversing these things anyways for other reasons.

Thanks.

> Can you work on the next bit you mentioned, making
> sure the corresponding idev is still alive when we add
> a neighbour with its neigh_parms to the hash table?

Sure.  Actually I prefer to do it by ref counting neigh_parms directly.
I'll send you a patch soon.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>