netdev
[Top] [All Lists]

Re: [PATCH] Allow setting dev->weight using ip(8)

To: Eric Lemoine <eric.lemoine@xxxxxxxxx>
Subject: Re: [PATCH] Allow setting dev->weight using ip(8)
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Mon, 30 Aug 2004 16:58:51 -0700
Cc: hadi@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <5cac192f0408300735f05aa2d@mail.gmail.com>
Organization: DaveM Loft Enterprises
References: <5cac192f040830035669628d1@mail.gmail.com> <1093868860.1075.573.camel@jzny.localdomain> <1093869740.1076.587.camel@jzny.localdomain> <5cac192f0408300735f05aa2d@mail.gmail.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 30 Aug 2004 16:35:57 +0200
Eric Lemoine <eric.lemoine@xxxxxxxxx> wrote:

> > As Dave pointed out any new attributes go to the end of the enumeration.
> > It may not matter in this case if Dave hasnt applied Thomas' patch.
> > Otherwise IFLA_WEIGHT should be last.
> 
> Right.
> 
> New patch attached.

Please make a patch against Linus's current tree.
I put the rest of your rtnetlink device interface
changes in, and your patches here duplicate all of
that.

I agree also with Jamel wrt. ioctl(), let's not go
there if possible. :-)

<Prev in Thread] Current Thread [Next in Thread>