Re: RFC/PATCH capture qdisc requeue event in stats

["David S. Miller" <davem@xxxxxxxxxx>]

On 30 Aug 2004 18:14:48 -0400
jamal <hadi@xxxxxxxxxx> wrote:

> 4) old kernel +  new tc --> will bomb (sizeof check will fail)
> 
> Cant think of something smart to do with option #4. I have contemplated
> playing with offsetoff() etc. The best thing i can think of right
> now is to complain about it as in that fprintf()
> 
> Thoughts?

Check the size, if it matches the older tc_stats size sans
requeue stat addition, then don't try to reference that struct member.

        if (RTA_PAYLOAD(tb[TCA_STATS]) == sizeof(struct tc_stats_old)) {
                /* report everything sans requeue */
        } else if (RTA_PAYLOAD(tb[TCA_STATS]) == sizeof(struct tc_stats)) {
                /* report all stats, including requeue */
        } else {
                /* report error, etc. */
        }