| To: | Pekka Pietikainen <pp@xxxxxxxxxx> |
|---|---|
| Subject: | [PATCH][1/4] b44: Ignore carrier lost errors |
| From: | Florian Schirmer <jolt@xxxxxxxxxx> |
| Date: | Sun, 29 Aug 2004 22:33:00 +0200 |
| Cc: | jgarzik@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <200408292218.00756.jolt@tuxbox.org> |
| References: | <200408292218.00756.jolt@tuxbox.org> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | KMail/1.7 |
Hi,
some (?) hardware seems to be buggy and is reporting bogus carrier lost
values. Both reference implementations from Broadcom indicate that this
counter is not reliable and therefore ignore it. We should do the same.
"Fixes" the carrier lost problem i've seen.
Regards,
Florian
Signed-off-by: Florian Schirmer <jolt@xxxxxxxxxx>
--- linux/drivers/net/b44.c-old1 2004-08-29 16:29:08.000000000 +0200
+++ linux/drivers/net/b44.c 2004-08-29 16:27:00.000000000 +0200
@@ -1347,7 +1347,10 @@ static struct net_device_stats *b44_get_
hwstat->rx_symbol_errs);
nstat->tx_aborted_errors = hwstat->tx_underruns;
+#if 0
+ /* Carrier lost counter seems to be broken for some devices */
nstat->tx_carrier_errors = hwstat->tx_carrier_lost;
+#endif
return nstat;
}
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH][0/4] b44: Cleanup and bcm47xx support, Florian Schirmer |
|---|---|
| Next by Date: | [PATCH][2/4] b44: Cleanup SiliconBackplane definitions/functions, Florian Schirmer |
| Previous by Thread: | [PATCH][0/4] b44: Cleanup and bcm47xx support, Florian Schirmer |
| Next by Thread: | Re: [PATCH][1/4] b44: Ignore carrier lost errors, Jeff Garzik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |