netdev
[Top] [All Lists]

Re: [PATCH 2.6] netem update

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH 2.6] netem update
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Fri, 27 Aug 2004 16:56:59 -0700
Cc: hadi@xxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040827121752.6b7fdf82@dell_ss3.pdx.osdl.net>
References: <20040827121752.6b7fdf82@dell_ss3.pdx.osdl.net>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 27 Aug 2004 12:17:52 -0700
Stephen Hemminger <shemminger@xxxxxxxx> wrote:

> This is a third revision of the netem extensions which provides
>       * packet duplication
>       * correlated random number
>       * loading distribution table
> 
> The API is backwards compatible and now uses nested elements to allow
> for easier future changes.

Looks great, applied.  A 2.4.x version is coming? :-)

Also, if someone is bored, can we get the pkt_sched.h
enumeration stuff cleaned up a bit?  I mean, instead
of all of these error prone FOO_MAX tricks, just do
what we do for the netlink headers.

enum {
        FOO_A,
        FOO_B,
        ...
        __FOO_MAX,
};

#define FOO_MAX         (__FOO_MAX - 1)

This way to add new enumerations is just a one line
change and less error prone.

<Prev in Thread] Current Thread [Next in Thread>