netdev
[Top] [All Lists]

Re: [PATCH] Prevent crash on ip_conntrack removal

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [PATCH] Prevent crash on ip_conntrack removal
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 19 Aug 2004 08:14:28 -0700
Cc: laforge@xxxxxxxxxxxxx, okir@xxxxxxx, netdev@xxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4124BF7E.7090304@trash.net>
References: <20040818091352.GB6507@suse.de> <20040819101159.GC3921@sunbeam.de.gnumonks.org> <20040819071846.2d0d6120.davem@redhat.com> <4124BF7E.7090304@trash.net>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 19 Aug 2004 16:55:58 +0200
Patrick McHardy <kaber@xxxxxxxxx> wrote:

> These are Olaf's patches. I agree with Harald that the second
> patch is better. I've fixed it up so it applies with the recent
> ip_fragment.c changes.

I have a better idea.

Instead of setting skb->dst to NULL, it should set it to some
NULL destination entry which just frees up the packets.  Then
no special case handling.  skb->dst==NULL packets should never
get into the fragment queue to begin with.

<Prev in Thread] Current Thread [Next in Thread>