Re: [PATCH] Move inetdev/ifa over to RCU

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Sun, Aug 15, 2004 at 07:08:23PM -0700, David S. Miller wrote:
>
> > Do we really care about the zero return value of inet_select_addr()
> > here? What about the other calls to inet_select_addr()?
> 
> It won't return zero, typically it will return loopback's IP
> (with preference to any non-loopback addresses assigned to
>  the loopback device).  This is being used for source address
> selection.

It will return zero if there is no in_dev at all.  Perhaps what
we should do is get inet_select_addr() to get the address from
other devices in that case as well?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt