netdev
[Top] [All Lists]

Re: neigh_create/inetdev_destroy race?

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: neigh_create/inetdev_destroy race?
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Sun, 15 Aug 2004 19:14:50 -0700
Cc: shemminger@xxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040814062703.GA4806@gondor.apana.org.au>
References: <20040813090314.448c971d@dell_ss3.pdx.osdl.net> <20040813093838.6961c0d4.davem@redhat.com> <20040813215602.GA15870@gondor.apana.org.au> <20040813151923.3311b4f0.davem@redhat.com> <20040814003428.GA17760@gondor.apana.org.au> <20040813173924.6d05be15.davem@redhat.com> <20040814005411.GA18350@gondor.apana.org.au> <20040814012513.GA721@gondor.apana.org.au> <20040814013030.GA2042@gondor.apana.org.au> <20040814050848.GA11874@gondor.apana.org.au> <20040814062703.GA4806@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 14 Aug 2004 16:27:03 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> Is there any thing that prevents the following scenario from occuring?
> 
> CPU0                                  CPU1
> neigh_create
>                                       inet_del_ifa
>                                               notifier_call_chain
>                                                       neigh_ifdown
>                                               inetdev_destroy
>       arp_constructor
>               neigh->parms =
>                       in_dev->arp_parms
>                                                       in_dev->dead = 1
>                                                       in_dev->dev->ip_ptr =
>                                                               NULL
>                                                       neigh_parms_release
>       n->parms->neigh_setup => BUG

Is there anything other than hostess_sv11.c, sealevel.c, and shaper.c
which are using n->parms->neigh_setup at all?

This seems to be a very obscure special case hack, which perhaps we
can removee entirely.

<Prev in Thread] Current Thread [Next in Thread>