Re: [PATCH] Move inetdev/ifa over to RCU

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Fri, Aug 13, 2004 at 03:19:23PM -0700, David S. Miller wrote:
> On Sat, 14 Aug 2004 07:56:02 +1000
> Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > Now had you put this barrier between the reading of ip_ptr and
> > the checking of in_dev->dead, then the race would've been closed.

Actually even that won't close the race so the barrier is completely
unnecessary.

> > But I still prefer to move the work into inetdev_destroy.
> 
> Ok I see now.  I've added your patch, it seems correct.

Thanks.  I presume you've reversed the previous patch as well?

BTW, it looks like you can remove inetdev_lock altogether.  All its
users already assume that they don't race against each other by
taking the rtnl lock.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt