netdev
[Top] [All Lists]

Re: [PATCH 2.6.8-rc3-mm1 1/2] 8139too: Rx fifo/overflow recovery

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [PATCH 2.6.8-rc3-mm1 1/2] 8139too: Rx fifo/overflow recovery
From: Francois Romieu <romieu@xxxxxxxxxxxxx>
Date: Thu, 12 Aug 2004 00:32:43 +0200
Cc: Andrew Morton <akpm@xxxxxxxx>, Pasi Sjoholm <ptsjohol@xxxxxxxxx>, Hector Martin <hector@xxxxxxxxxxxxxx>, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <411A70CB.8060101@pobox.com>
References: <20040805234336.A15407@electric-eye.fr.zoreil.com> <411A70CB.8060101@pobox.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
Jeff Garzik <jgarzik@xxxxxxxxx> :
[...]
> You _want_ to update those registers on every packet.  Otherwise the 
> crappy 8139 chip breaks.

The affected users noticed a clear difference when the update was in
the no-packet branch instead of the packet processing loop. Btw the
excerpt of the documentation outlined by Hirofumi san suggests that
this update makes sense.

Any objection/suggestion regarding a patch which would allow the update
in both branches ?

--
Ueimor

<Prev in Thread] Current Thread [Next in Thread>