| To: | Denis Vlasenko <vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] #1: cleanup, add reset debug message |
| From: | mcgrof@xxxxxxxxxxxxxxxxxxxx (Luis R. Rodriguez) |
| Date: | Tue, 10 Aug 2004 20:18:09 -0400 |
| Cc: | prism54-devel@xxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <200408101823.15792.vda@port.imtp.ilyichevsk.odessa.ua> |
| Mail-followup-to: | Denis Vlasenko <vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>, prism54-devel@xxxxxxxxxxx, netdev@xxxxxxxxxxx |
| Organization: | Rutgers University Student Linux Users Group |
| References: | <200408101823.15792.vda@port.imtp.ilyichevsk.odessa.ua> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.28i |
Denis,
this one seems fine to me although for netdev we'll need a patch
against linux kernel dirs (linux-2.6.8-rc4/drivers/net/prism54/) instead
of cvs tarball.
Jeff if you accept I'll apply to our CVS.
Luis
On Tue, Aug 10, 2004 at 06:23:15PM +0300, Denis Vlasenko wrote:
> Hi Luis,
>
> This is a mostly trivial patch on top of today's prism54 CVS.
>
> * Move assignment out of if()
> * Remove trailing space from printk
> * Eliminate not needed local 'u32 reg'
> * Add a comment about undoc bits
> * Add #define VEC_SIZE, use it as appropriate
> * Add a pair of printks to reset error code path (our current area of trouble)
> * Make printk text less confusing
>
> Please apply.
> --
> vda
--
GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84 A34A 6ADD 4937 E20A 525E
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [BK PATCHES] 2.6.8-rc net driver fixes, Jeff Garzik |
|---|---|
| Next by Date: | Re: [PATCH] #2: add more reset debug messages, Luis R. Rodriguez |
| Previous by Thread: | [PATCH] #1: cleanup, add reset debug message, Denis Vlasenko |
| Next by Thread: | [PATCH] #2: add more reset debug messages, Denis Vlasenko |
| Indexes: | [Date] [Thread] [Top] [All Lists] |