netdev
[Top] [All Lists]

Re: [PATCH 2.6] vlan - device refcount bug.

To: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH 2.6] vlan - device refcount bug.
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Mon, 9 Aug 2004 16:49:20 -0700
Cc: shemminger@xxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <410FF740.5060903@candelatech.com>
References: <20040803131425.503f8f45@dell_ss3.pdx.osdl.net> <410FF740.5060903@candelatech.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 03 Aug 2004 13:36:16 -0700
Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote:

> Stephen Hemminger wrote:
> > If you rmmod a network device that is in a vlan, the system hangs waiting
> > for the refcount to go to zero, because it is -1.  The problem is that the
> > vlan notifier does an extra dev_put in NETDEV_UNREGISTER case of notifier.
> 
> Good catch.  It would seem to me that it would be good to have a
> BUG() or similar to catch any instance of the reference count going
> negative.

I'd likely accept such a patch. :-)

<Prev in Thread] Current Thread [Next in Thread>