netdev
[Top] [All Lists]

Re: [PATCH 2.6 2/5]: refcount qdisc->dev

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [PATCH 2.6 2/5]: refcount qdisc->dev
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 4 Aug 2004 09:36:04 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <410FADBC.6000904@trash.net>
References: <410FADBC.6000904@trash.net>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 03 Aug 2004 17:22:36 +0200
Patrick McHardy <kaber@xxxxxxxxx> wrote:

> This patch adds refcounting for qdisc->dev to avoid accessing freed memory
> from the __qdisc_destroy rcu-callback when the device is unregistered. 
> Without
> refcounting netdev_wait_allrefs could free the device before __qdisc_destroy
> is done.

We do need this.  Applied, thanks Patrick.


<Prev in Thread] Current Thread [Next in Thread>