netdev
[Top] [All Lists]

Re: [PATCH] Trivial ipv6 fix.

To: suckfish@xxxxxxxxxx
Subject: Re: [PATCH] Trivial ipv6 fix.
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Mon, 02 Aug 2004 06:59:40 -0700 (PDT)
Cc: davem@xxxxxxxxxx, pekkas@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <1091434328.16469.5.camel@localhost.localdomain>
Organization: USAGI Project
References: <1091434328.16469.5.camel@localhost.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
In article <1091434328.16469.5.camel@xxxxxxxxxxxxxxxxxxxxx> (at Mon, 02 Aug 
2004 20:12:08 +1200), Ralph Loader <suckfish@xxxxxxxxxx> says:

> ipv6_addr_hash doesn't do what it's comment says.  The comment was
> probably what was intended, not that it'll make much difference in
> practice.

Oops, David, please apply this.

> Signed-off-by: Ralph Loader <suckfish@xxxxxxxxxx>
Signed-off-by: Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>

===== include/net/addrconf.h 1.17 vs edited =====
--- 1.17/include/net/addrconf.h 2004-07-29 02:00:50 +09:00
+++ edited/include/net/addrconf.h       2004-08-02 22:57:38 +09:00
@@ -178,8 +178,8 @@
         * This will include the IEEE address token on links that support it.
         */
 
-       word = addr->s6_addr[2] ^ addr->s6_addr32[3];
-       word  ^= (word>>16);
+       word = addr->s6_addr32[2] ^ addr->s6_addr32[3];
+       word ^= (word >> 16);
        word ^= (word >> 8);
 
        return ((word ^ (word >> 4)) & 0x0f);

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@xxxxxxxxxxxxxx>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

<Prev in Thread] Current Thread [Next in Thread>