netdev
[Top] [All Lists]

Re: [IPSEC] xfrm_alloc_spi always succeeds on non-trivial range

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [IPSEC] xfrm_alloc_spi always succeeds on non-trivial range
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Sat, 31 Jul 2004 23:45:13 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20040731020044.GA13830@gondor.apana.org.au>
References: <20040731020044.GA13830@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 31 Jul 2004 12:00:44 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> xfrm_alloc_spi will always succeed if minspi < maxspi, even if
> minspi + 1 == maxspi.  If the range is already occupied this
> will obviously lead to breakage.
> 
> Of course this is very unlikely to occur in reality due to the
> size of the range.  Although with IPCOMP it might actually happen
> on a very large server.
> 
> The fix is obivous.

Indeed, applied.

You're certainly making the rounds auditing the SPI handling lately.
:-)  It is much appreciated.


<Prev in Thread] Current Thread [Next in Thread>