netdev
[Top] [All Lists]

Re: [IPSEC] Move generic encap code into xfrm6_output

To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@xxxxxxxxxxxxxx>
Subject: Re: [IPSEC] Move generic encap code into xfrm6_output
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 29 Jul 2004 07:38:09 +1000
Cc: davem@xxxxxxxxxx, usagi-core@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040729.010159.77611229.yoshfuji@linux-ipv6.org>
References: <20040725104028.GA24547@gondor.apana.org.au> <20040725.093617.15482200.yoshfuji@linux-ipv6.org> <20040725213122.GA30819@gondor.apana.org.au> <20040729.010159.77611229.yoshfuji@linux-ipv6.org>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040523i
On Thu, Jul 29, 2004 at 01:01:59AM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
> 
> diff -ru linux26-ipsectunnel/net/ipv6/xfrm6_output.c 
> linux26-ipsectunnel.fix/net/ipv6/xfrm6_output.c
> --- linux26-ipsectunnel/net/ipv6/xfrm6_output.c       Thu Jul 29 00:35:07 2004
> +++ linux26-ipsectunnel.fix/net/ipv6/xfrm6_output.c   Thu Jul 29 00:37:35 2004
> @@ -1,5 +1,6 @@
>  /*
>   * xfrm6_output.c - Common IPsec encapsulation code for IPv6.
> + * Copyright (C) 2002 USAGI/WIDE Project
>   * Copyright (c) 2004 Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
>   * 
>   * This program is free software; you can redistribute it and/or

Great.  I've included the updated patch here.

> BTW, please consider followings when you send multiple patches.
> (I was confused when I tried applying your patches.)

I agree with your suggestions.

>  2. It would not be so good to post incremental patch
>     if the the base change might introduce discussion.

I presume you mean the incremental patch I posted in this thread.
That was only meant to illustrate the bugs in the original patch.
It was posted alongside with a complete patch.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>