netdev
[Top] [All Lists]

Re: [PATCH] de-inline qdiscipline locking functions.

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH] de-inline qdiscipline locking functions.
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 28 Jul 2004 18:55:01 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20040726113402.25ba72ee@dell_ss3.pdx.osdl.net>
References: <20040726113402.25ba72ee@dell_ss3.pdx.osdl.net>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 26 Jul 2004 11:34:02 -0700
Stephen Hemminger <shemminger@xxxxxxxx> wrote:

> This qdisc code has several inline functions for locking that is only
> used when adding/deleting queuing disciplines; so make them functions
> instead.  The new qdisc_lock_tree encapsulates the locking used throughout
> this code.
> 
> Also qdisc_run() is only called from net/core/dev.c so it should be
> defined there.

Looks good, thanks Stephen.

<Prev in Thread] Current Thread [Next in Thread>