netdev
[Top] [All Lists]

Re: [IPCOMP6] Fix ICMP type check

To: James Morris <jmorris@xxxxxxxxxx>
Subject: Re: [IPCOMP6] Fix ICMP type check
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Thu, 22 Jul 2004 12:19:52 -0700
Cc: herbert@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, xma@xxxxxxxxxx
In-reply-to: <Pine.LNX.4.58.0407221025010.7557@devserv.devel.redhat.com>
References: <20040722113429.GA15083@gondor.apana.org.au> <Pine.LNX.4.58.0407221025010.7557@devserv.devel.redhat.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 22 Jul 2004 10:25:24 -0400 (EDT)
James Morris <jmorris@xxxxxxxxxx> wrote:

> On Thu, 22 Jul 2004, Herbert Xu wrote:
> 
> > It looks like IPCOMP was missed when the same problem was fixed in
> > AH/ESP.
> 
> What about esp4/ah4/ipcomp?  They look wrong too.

Those are testing something else, and I believe their tests
are correct.  They are saying:

        if (type != X || code != Y)
                return;

in these cases Herbert is mentioning it is testing against multiple
possible settings of just "type".

Herbert, I'll apply your patch, thanks.

<Prev in Thread] Current Thread [Next in Thread>