Re: [CRYPTO] Fix stack overrun in crypt()

["David S. Miller" <davem@xxxxxxxxxx>]

On Thu, 15 Jul 2004 21:48:40 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> The stack allocation in crypt() is bogus as whether tmp_src/tmp_dst
> is used is determined by factors unrelated to nbytes and
> src->length/dst->length.
> 
> Since the condition for whether tmp_src/tmp_dst are used is very
> complex, let's allocate them always instead of guessing.
> 
> This fixes a number of weird crashes including those AES crashes
> that people have been seeing with the 2.4 backport + ipt_conntrack.

Applied, thanks Herbert.

> PS I think someone should double-check the logic in the scatterwalk
> stuff, especially the whichbuf bits.

I've looked at this before, when it went in, but I'll double-
check it now.