| To: | Martin Diehl <lists@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Drop ISA dependencies from IRDA drivers |
| From: | Jean Tourrilhes <jt@xxxxxxxxxxxxxxxxxx> |
| Date: | Thu, 15 Jul 2004 15:42:35 -0700 |
| Address: | HP Labs, 1U-17, 1501 Page Mill road, Palo Alto, CA 94304, USA. |
| Cc: | Andi Kleen <ak@xxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>, netdev@xxxxxxxxxxx, irda-users@xxxxxxxxxxxxxxxxxxxxx, jt@xxxxxxxxxx, the_nihilant@xxxxxxxxxxxxx, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx> |
| E-mail: | jt@hpl.hp.com |
| In-reply-to: | <Pine.LNX.4.44.0407160027410.14037-100000@notebook.home.mdiehl.de> |
| Organisation: | HP Labs Palo Alto |
| References: | <20040715215552.GA46635@muc.de> <Pine.LNX.4.44.0407160027410.14037-100000@notebook.home.mdiehl.de> |
| Reply-to: | jt@xxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.28i |
On Fri, Jul 16, 2004 at 12:32:44AM +0200, Martin Diehl wrote:
> On 15 Jul 2004, Andi Kleen wrote:
>
> > Remove wrong ISA dependencies for IRDA drivers.
> >
> >
> > diff -u linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig-o
> > linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig
> > --- linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig-o 2004-07-12
> > 06:09:05.000000000 +0200
> > +++ linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig 2004-07-15
> > 18:33:48.000000000 +0200
> > @@ -310,7 +310,7 @@
> >
> > config NSC_FIR
> > tristate "NSC PC87108/PC87338"
> > - depends on IRDA && ISA
> > + depends on IRDA
>
>
> Admittedly I haven't tried either, but I'm pretty sure this patch will
> break building those drivers because they are calling irda_setup_dma -
> which is CONFIG_ISA. Maybe this can be dropped but I don't see what's
> wrong with !64BIT instead.
irda_setup_dma was (supposedly) fixed in 2.6.8-rc1, and no
longer depend on CONFIG_ISA. Those driver are supposed to work on 64
bits.
> Martin
Jean
|
| Previous by Date: | Re: [PATCH] Drop ISA dependencies from IRDA drivers, Jean Tourrilhes |
|---|---|
| Next by Date: | Network device driver probe issues, Anton Blanchard |
| Previous by Thread: | Re: [PATCH] Drop ISA dependencies from IRDA drivers, Martin Diehl |
| Next by Thread: | Re: [PATCH] Drop ISA dependencies from IRDA drivers, Martin Diehl |
| Indexes: | [Date] [Thread] [Top] [All Lists] |