Re: pskb change in dst->output

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Sat, Jul 10, 2004 at 06:42:28AM +1000, herbert wrote:
> 
> So unless I've missed another case where someone will pass a clone
> down, it is safe to change the checksum on the TCP clones.

Please note that even if you decide at the API-level that it is not
OK for dst->output() functions to modify anything beyond the IP
headers, we still don't need to copy the entire skb.

Since it's already a clone anyway, skb_cow() suffices to allow
changing the checksum.

Is there a situation where someone will pass a shared (not cloned) skb
down on the netfilter path? If not, then we can do skb_cow() there as
well.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt