| To: | James Morris <jmorris@xxxxxxxxxx> |
|---|---|
| Subject: | Re: pskb change in dst->output |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Fri, 9 Jul 2004 18:14:43 +1000 |
| Cc: | "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <20040708040235.GA32678@gondor.apana.org.au> |
| References: | <20040708011100.GA31600@gondor.apana.org.au> <Xine.LNX.4.44.0407072327390.29365-100000@thoron.boston.redhat.com> <20040708040235.GA32678@gondor.apana.org.au> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040523i |
On Thu, Jul 08, 2004 at 02:02:35PM +1000, herbert wrote: > > That's only because the dst->output() functions are calling > skb_checksum_help(). Since those same functions assume the > skb to be "uncloned" anyway (they modify it directly by adding > headers etc.), they only need to call a version of > skb_checksum_help() that does not do a copy of the skb. If there are no objections, I'd like to create a version of skb_checksum_help() that doesn't copy the packet, and call that version from ah_output()/esp_output()/ipcomp_output(). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH Linux-2.6.7-bk19] prism54 freq to channel incorrect for 5GHz, Vladimir Kondratiev |
|---|---|
| Next by Date: | IPCOMP scratch buffer (was: [Openswan dev] IPComp), Herbert Xu |
| Previous by Thread: | Re: pskb change in dst->output, Herbert Xu |
| Next by Thread: | Re: pskb change in dst->output, James Morris |
| Indexes: | [Date] [Thread] [Top] [All Lists] |