Re: pskb change in dst->output

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Wed, Jul 07, 2004 at 11:34:59PM -0400, James Morris wrote:
> 
> We need to pass a pointer to skb to skb->dst->output() because the skb can
> be changed by skb_checksum_help() in one of these output paths.  Further
> iteration would otherwise pass an incorrect (freed) skb.

That's only because the dst->output() functions are calling
skb_checksum_help().  Since those same functions assume the
skb to be "uncloned" anyway (they modify it directly by adding
headers etc.), they only need to call a version of
skb_checksum_help() that does not do a copy of the skb.

This is what dst->output() did before this change anyway.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt