netdev
[Top] [All Lists]

Re: pskb change in dst->output

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: pskb change in dst->output
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 8 Jul 2004 09:12:21 +1000
Cc: jmorris@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040707150132.5dc470b6.davem@redhat.com>
References: <20040707130652.GA26822@gondor.apana.org.au> <Xine.LNX.4.44.0407071013080.26759-100000@thoron.boston.redhat.com> <20040707212805.GA29899@gondor.apana.org.au> <20040707150132.5dc470b6.davem@redhat.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040523i
On Wed, Jul 07, 2004 at 03:01:32PM -0700, David S. Miller wrote:
> On Thu, 8 Jul 2004 07:28:05 +1000
> Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > OK.  Can you please tell me which caller of dst_output() passes
> > a cloned skb to it?
> 
> The case James's patch tries to deal with is when multicast
> loops back packets to localhost, see ip_mc_output().
> Since the SKB is a clone, if we do anything with the checksum
> state of the clone, this messes up the hw checksumming state
> of the original SKB and we get output packets with corrupt
> checksums.

Thanks.  I have no problems with that.  But ip_mc_output() as far
as I can see does not call dst_output.

So is there a caller to dst_output that does this as well?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>