netdev
[Top] [All Lists]

Re: [PATCH] net/ipv4/ipmr.c fixes

To: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] net/ipv4/ipmr.c fixes
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Wed, 7 Jul 2004 14:09:45 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <877jtfmxg9.fsf@devron.myhome.or.jp>
References: <877jtfmxg9.fsf@devron.myhome.or.jp>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 08 Jul 2004 04:25:26 +0900
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> wrote:

> - pim_protocol warning fix
> 
> - ipmr_vif_open() and ipmr_mfc_open() allocates the memory, so it
>   should use seq_release_private().
> 
> - ipmr_mfc_seq_xxx is using it->cache, in order to control whether
>   unlock should be do or not, but it->cache was not initialized in
>   ipmr_mfc_seq_start(). So it can point the previous state if user
>   did seek(). This become to the cause of twice unlock.

Looks good, patch applied.  Thanks!

<Prev in Thread] Current Thread [Next in Thread>