netdev
[Top] [All Lists]

Re: [PATCH] fix tcp_default_win_scale.

To: Jan-Benedict Glaw <jbglaw@xxxxxxxxxx>
Subject: Re: [PATCH] fix tcp_default_win_scale.
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Tue, 6 Jul 2004 13:17:31 -0700
Cc: linux-net@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040706185856.GN18841@lug-owl.de>
References: <32886.63.170.215.71.1088564087.squirrel@www.osdl.org> <20040629222751.392f0a82.davem@redhat.com> <20040630152750.2d01ca51@dell_ss3.pdx.osdl.net> <20040630153049.3ca25b76.davem@redhat.com> <20040701133738.301b9e46@dell_ss3.pdx.osdl.net> <20040701140406.62dfbc2a.davem@redhat.com> <20040702013225.GA24707@conectiva.com.br> <20040706093503.GA8147@outpost.ds9a.nl> <20040706114741.1bf98bbe@dell_ss3.pdx.osdl.net> <20040706185856.GN18841@lug-owl.de>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 6 Jul 2004 20:58:56 +0200
Jan-Benedict Glaw <jbglaw@xxxxxxxxxx> wrote:

> On Tue, 2004-07-06 11:47:41 -0700, Stephen Hemminger <shemminger@xxxxxxxx>
> wrote in message <20040706114741.1bf98bbe@xxxxxxxxxxxxxxxxxxxxx>:
> 
> > I propose that the following that will avoid sending window scaling that
> > is big enough to break in these cases unless the tcp_rmem has been 
> > increased.
> > It will keep default configuration from blowing in a corrupt world.
> 
> I'm not sure if this is the right way to react. I'd think it's okay to
> give the user the possibility to scale the window so that it works with
> his b0rk3d firewall, but default behavior should be to do whatever the
> protocol dictates/allows.

I totally agree, and that's why the sysctl is there for people to
tweak as they desire.

Jan, any particular reason you removed so much stuff (in particular
netdev@xxxxxxxxxxx) from the CC: list in your posting here?

<Prev in Thread] Current Thread [Next in Thread>