netdev
[Top] [All Lists]

Re: [PATCH] Gigabit Ethernet support for forcedeth

To: Manfred Spraul <manfred@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Gigabit Ethernet support for forcedeth
From: Pavel Machek <pavel@xxxxxx>
Date: Sun, 4 Jul 2004 20:27:55 +0200
Cc: linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <40E25328.8020102@colorfullife.com>
References: <40E25328.8020102@colorfullife.com>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.5.1+cvs20040105i
Hi!

> Attached is an update for the patch that adds support for the gigabit 
> ethernet nic in the nForce 250 Gb chipset.
> 
> There were two changes from the previous patch:
> - clear the PHY_HALF flag if the nic is in half duplex.
> - remove the setflags / setlen helper functions: the ring entries are 
> visible to the hardware, I don't like the read/modify/write cycles.
> 
> It passes my own tests with 100 MBit half duplex, 100 MB full duplex and 
> 1 GBit full duplex.

...

> --- 2.6/drivers/net/forcedeth.c       2004-06-30 07:27:50.330753976 +0200
> +++ build-2.6/drivers/net/forcedeth.c 2004-06-30 07:27:25.579516736 +0200
> @@ -10,8 +10,11 @@
>   * trademarks of NVIDIA Corporation in the United States and other
>   * countries.
>   *
> - * Copyright (C) 2003 Manfred Spraul
> + * Copyright (C) 2003,4 Manfred Spraul
>   * Copyright (C) 2004 Andrew de Quincey (wol support)
> + * Copyright (C) 2004 Carl-Daniel Hailfinger (invalid MAC handling, insane
> + *           IRQ rate fixes, bigendian fixes, cleanups, verification)
> + * Copyright (c) 2004 NVIDIA Corporation

NVidia has copyright on driver created by reverse engeneering their
hardware? Funny ;-). If NVIDIA really cooperates, perhaps its time to
make the name more friendly to them?
                                                                Pavel

-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!

<Prev in Thread] Current Thread [Next in Thread>