Re: [BUGS] [CHECKER] 99 synchronization bugs and a lock summary database

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Sat, Jul 03, 2004 at 02:42:47PM +0900, OGAWA Hirofumi wrote:
>  
> @@ -1854,7 +1850,13 @@ out:
>  out_kfree:
>       kfree(s);
>       goto out;
> +}
>  
> +static int ipmr_mfc_release(struct inode *inode, struct file *file)
> +{
> +     struct seq_file *seq = file->private_data;
> +     kfree(seq->private);
> +     return seq_release(inode, file);
>  }
>  
>  static struct file_operations ipmr_mfc_fops = {
> @@ -1862,7 +1864,7 @@ static struct file_operations ipmr_mfc_f
>       .open    = ipmr_mfc_open,
>       .read    = seq_read,
>       .llseek  = seq_lseek,
> -     .release = seq_release,
> +     .release = ipmr_mfc_release,
>  };
>  #endif       

This is a good catch.  But you probably need to fix the vif stuff as
well.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt