netdev
[Top] [All Lists]

Re: [XFRM] Convert XFRM_MSG_* macros to an enum

To: herbert@xxxxxxxxxxxxxxxxxxx
Subject: Re: [XFRM] Convert XFRM_MSG_* macros to an enum
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Sat, 03 Jul 2004 19:00:42 +0900 (JST)
Cc: davem@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040703095215.GA16195@gondor.apana.org.au>
Organization: USAGI Project
References: <20040703095215.GA16195@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
In article <20040703095215.GA16195@xxxxxxxxxxxxxxxxxxx> (at Sat, 3 Jul 2004 
19:52:15 +1000), Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> says:

> I've cleaned up the existing MSG definitions by converting them to
> an enum.  This should make future additions slightly easier in that
> XFRM_MSG_MAX won't have to be touched again.
> 
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Well, I think we'd better to do

 #define XFRM_MSG_GETSA XFRM_MSG_GETSA

etc. because this would break (future) applications which do
#ifdef.

--yoshfuji

<Prev in Thread] Current Thread [Next in Thread>