netdev
[Top] [All Lists]

Re: [PATCH] (4/4) packet scheduler -- use get_jiffies_64

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH] (4/4) packet scheduler -- use get_jiffies_64
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Tue, 29 Jun 2004 14:46:49 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20040629140021.367695ff@dell_ss3.pdx.osdl.net>
References: <20040629140021.367695ff@dell_ss3.pdx.osdl.net>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 29 Jun 2004 14:00:21 -0700
Stephen Hemminger <shemminger@xxxxxxxx> wrote:

> The packet scheduler simulates 64 bit jiffies on 32 bit platforms by running
> a timer keeping a mark and and offset.  Since there is no locking and this is
> racy and doesn't handle jiffie wrap real well.
> 
> We can use get_jiffies_64 on 2.6 do get what is needed.
> The downside is the overhead of a function call, and a cache miss in 
> get_jiffies_64.

Looks great, applied.

<Prev in Thread] Current Thread [Next in Thread>