netdev
[Top] [All Lists]

Re: old NLMSG_OK fix

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: old NLMSG_OK fix
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Sun, 27 Jun 2004 20:51:33 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20040627171552.GA2797@lst.de>
References: <20040531160427.GA19581@lst.de> <20040627171552.GA2797@lst.de>
Sender: netdev-bounce@xxxxxxxxxxx
On Sun, 27 Jun 2004 19:15:52 +0200
Christoph Hellwig <hch@xxxxxx> wrote:

> http://oss.sgi.com/projects/netdev/archive/2000-09/msg00001.html

It works because there is always 16 bytes of scratch at the end of an
SKB more than was allocated for the actual data.  So blindly deref'ing
the nlmsg_len value is fine here.

There is no danger for OOPS's or kernel corruption.

I believe I responded exactly like this the last time this
patch was presented.

<Prev in Thread] Current Thread [Next in Thread>