Re: [PATCH][ATM]: fix sparse checker warnings

["David S. Miller" <davem@xxxxxxxxxx>]

On Sat, 26 Jun 2004 15:52:30 -0700
Chris Wedgwood <cw@xxxxxxxx> wrote:

> > +++ b/net/atm/br2684.c      2004-06-22 14:04:02 -07:00
> > @@ -562,7 +562,7 @@
> >     atmvcc->push = br2684_push;
> >     skb_queue_head_init(&copy);
> >     skb_migrate(&atmvcc->sk->sk_receive_queue, &copy);
> 
> > - - while ((skb = skb_dequeue(&copy))) {
> > +   while ((skb = skb_dequeue(&copy)) != NULL) {
> 
> I know it's a matter of style, but I really hate the 'assignment in
> conditional' warning sparse spews out, especially when many people,
> myself included really do write while ((a = b)) --- the extra
> parentheses as a compromise to keep gcc quiet.

I think warning for the ((a=b)) case is annoying but not annoying
enough to fight against it :)