| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [IPSEC] Drop bogus NAT-T printks in esp_input |
| From: | "David S. Miller" <davem@xxxxxxxxxx> |
| Date: | Sat, 26 Jun 2004 11:36:03 -0700 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <20040626100718.GA28367@gondor.apana.org.au> |
| References: | <20040625121147.GA11231@gondor.apana.org.au> <20040625123527.GA11685@gondor.apana.org.au> <20040625103928.3b1b3275.davem@redhat.com> <20040626015715.GA16496@gondor.apana.org.au> <20040626100718.GA28367@gondor.apana.org.au> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Sat, 26 Jun 2004 20:07:18 +1000 Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > On Sat, Jun 26, 2004 at 11:57:15AM +1000, herbert wrote: > > > > However, printing a warning and then continuing is definitely wrong. > > So expect a follow-up patch to drop the packet when encap_type is > > unknown in esp_input. > > Here is the patch to drop the packet if encap_type is unknown. > I've also removed the other two bogus printk's as they cannot > occur (printing a message is the last thing you want to do even > if they did occur :). Also applied, thanks. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [IPSEC] Remove run-time encap_type checks in esp4, David S. Miller |
|---|---|
| Next by Date: | Re: [UDP] Move common code out in udp_encap_rcv, David S. Miller |
| Previous by Thread: | [IPSEC] Drop bogus NAT-T printks in esp_input, Herbert Xu |
| Next by Thread: | Re: [IPSEC] Remove run-time encap_type checks in esp4, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |