On Thu, Jun 24, 2004 at 01:09:38AM -0700, Andrew Morton wrote:
>
> Current gcc CVS emits a memmove() when compiling this function, and the
> kernel link fails.
It's just an i386 bug. Other architectures have a proper out of line
memmove.
I would suggest to just not define __HAVE_ARCH_MEMMOVE, then lib/string.c
will do the right thing.
BTW if we don't want to supply these functions we should change
the kernel to compile with -ffreestanding. But so far at least
the common ports are good enough at that now that it isn't needed.
-Andi
Here's a patch: Or perhaps it would be better to just remove
this completely from asm/string.h, since I can see no sane reason
to inline memmove(). That would make the kernel smaller.
diff -u linux/include/asm-i386/string.h-o linux/include/asm-i386/string.h
--- linux/include/asm-i386/string.h-o 2004-03-21 21:11:56.000000000 +0100
+++ linux/include/asm-i386/string.h 2004-06-24 12:38:25.000000000 +0200
@@ -293,7 +293,7 @@
memcpy(x, y, sizeof(*(x))); \
})
-#define __HAVE_ARCH_MEMMOVE
+#ifndef IN_STRING_C
static inline void * memmove(void * dest,const void * src, size_t n)
{
int d0, d1, d2;
@@ -312,6 +312,7 @@
:"memory");
return dest;
}
+#endif
#define memcmp __builtin_memcmp
|