| To: | Stephen Hemminger <shemminger@xxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] [sparse] get rid of warnings from 8139too driver |
| From: | Francois Romieu <romieu@xxxxxxxxxxxxx> |
| Date: | Wed, 23 Jun 2004 01:15:56 +0200 |
| Cc: | Jeff Garzik <jgarzik@xxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <20040622135122.05be2be1@dell_ss3.pdx.osdl.net>; from shemminger@osdl.org on Tue, Jun 22, 2004 at 01:51:22PM -0700 |
| References: | <20040622135122.05be2be1@dell_ss3.pdx.osdl.net> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.2.5.1i |
Stephen Hemminger <shemminger@xxxxxxxx> : > Get rid of sparse warnings from 8139too driver. > * move start_thread which was inline into the open routine (only place > called). I can understand that rtl8139_start_thread() appears a bit late in the file but I appreciate the virtues of helpers functions as they document what the code is supposed to achieve. Just mho of course. -- Ueimor |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [RFT] convert syskonnect gigabit ether driver to PCI module interface, Stephen Hemminger |
|---|---|
| Next by Date: | Re: [RFT] convert syskonnect gigabit ether driver to PCI module interface, Jeff Garzik |
| Previous by Thread: | [PATCH] [sparse] get rid of warnings from 8139too driver, Stephen Hemminger |
| Next by Thread: | Re: [PATCH] [sparse] get rid of warnings from 8139too driver, Jeff Garzik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |