netdev
[Top] [All Lists]

Re: [patch-kj] net/ipv4/fib_hash.c: check kmem_cache_create()

To: max@xxxxxxx
Subject: Re: [patch-kj] net/ipv4/fib_hash.c: check kmem_cache_create()
From: YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx>
Date: Tue, 22 Jun 2004 08:51:21 +0900 (JST)
Cc: romieu@xxxxxxxxxxxxx, janitor@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx
In-reply-to: <20040621200420.GI1545@sputnik.stro.at>
Organization: USAGI Project
References: <20040621171832.GE1545@sputnik.stro.at> <20040622.032138.58652005.yoshfuji@linux-ipv6.org> <20040621200420.GI1545@sputnik.stro.at>
Sender: netdev-bounce@xxxxxxxxxxx
In article <20040621200420.GI1545@xxxxxxxxxxxxxxx> (at Mon, 21 Jun 2004 
22:04:20 +0200), maximilian attems <max@xxxxxxx> says:

> doesn't seem to be enough,
> because if (tb == NULL) fn_hash_kmem won't be freed, 
> or am i overseeing something?

I believe fn_hash_kmem is not required to (and should not) be freed even 
if kmalloc() fails for the new table.
Users in existing table should be able to continue using fn_hash_kmem.

--yoshfuji

<Prev in Thread] Current Thread [Next in Thread>